This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(parseKeyValue): ignore properties in prototype chain. #8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matsko can you give this a quick review? I'd like to check this in shortly as this is a kind of embarassing bug |
| var oldQ = Object.prototype.q; | ||
| Object.prototype.q = function(a,b,c,d,e,f,g) {}; | ||
|
|
||
| expect(parseKeyValue('q=123')).toEqual({ |
There was a problem hiding this comment.
all browsers will fail this without this fix.
Currently, any query parameter name which shadows a property of Object.prototype will cause issues, notably watch in Firefox for which this issue was reported.
|
|
||
|
|
||
| it('should ignore properties higher in the prototype chain', function() { | ||
| expect(parseKeyValue('toString=123')).toEqual({ |
There was a problem hiding this comment.
Refactored the test to not modify Object.prototype --- still fails without the change in Chrome
Previously, properties (typically functions) in the prototype chain (Object.prototype) would shadow query parameters, and cause them to be serialized incorrectly. This CL guards against this by using hasOwnProperty() to ensure that only own properties are a concern. Closes angular#8070 Fixes angular#8068
caitp
added a commit
to caitp/angular.js
that referenced
this pull request
Jul 4, 2014
Previously, properties (typically functions) in the prototype chain (Object.prototype) would shadow query parameters, and cause them to be serialized incorrectly. This CL guards against this by using hasOwnProperty() to ensure that only own properties are a concern. Closes angular#8070 Fixes angular#8068
ckknight
pushed a commit
to ckknight/angular.js
that referenced
this pull request
Jul 16, 2014
Previously, properties (typically functions) in the prototype chain (Object.prototype) would shadow query parameters, and cause them to be serialized incorrectly. This CL guards against this by using hasOwnProperty() to ensure that only own properties are a concern. Closes angular#8070 Fixes angular#8068
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, properties (typically functions) in the prototype chain
(Object.prototype) would shadow query parameters, and cause them to be
serialized incorrectly.
This CL guards against this by using hasOwnProperty() to ensure that only own
properties are a concern.
Fixes #8068